generated from nl-design-system/example
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable tokens studio transform group for voorbeeld thema #862
Merged
Robbert
merged 2 commits into
main
from
build/enable-tokens-studio-transform-group-voorbeeld-thema
Dec 18, 2024
Merged
feat: enable tokens studio transform group for voorbeeld thema #862
Robbert
merged 2 commits into
main
from
build/enable-tokens-studio-transform-group-voorbeeld-thema
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bddjong
force-pushed
the
build/enable-tokens-studio-transform-group-voorbeeld-thema
branch
from
December 16, 2024 12:00
58bd3d1
to
417d8cf
Compare
Ik vind dit een goed idee, als dit problemen oplevert mogen mensen bij mij klagen! |
Robbert
reviewed
Dec 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
=======================================
Coverage 89.50% 89.50%
=======================================
Files 19 19
Lines 1334 1334
Branches 167 178 +11
=======================================
Hits 1194 1194
Misses 139 139
Partials 1 1 ☔ View full report in Codecov by Sentry. |
bddjong
force-pushed
the
build/enable-tokens-studio-transform-group-voorbeeld-thema
branch
from
December 16, 2024 16:52
417d8cf
to
ec1d814
Compare
Robbert
previously approved these changes
Dec 18, 2024
Robbert
force-pushed
the
build/enable-tokens-studio-transform-group-voorbeeld-thema
branch
from
December 18, 2024 10:59
ec1d814
to
5977211
Compare
Robbert
previously approved these changes
Dec 18, 2024
Robbert
force-pushed
the
build/enable-tokens-studio-transform-group-voorbeeld-thema
branch
from
December 18, 2024 11:02
5977211
to
e6e7c45
Compare
Robbert
approved these changes
Dec 18, 2024
Robbert
deleted the
build/enable-tokens-studio-transform-group-voorbeeld-thema
branch
December 18, 2024 11:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result
This fixes the units but note that it does also transform the format of a few other tokens. Scroll down for more. Three test results had to have their expected output (a color hex) changed to lower case instead of upper case due to this. See the last commit.
Line heights
Diff
Colors with transparent or alpha
Diff
Font family notation
Diff